noblepaul commented on code in PR #972:
URL: https://github.com/apache/solr/pull/972#discussion_r946327978
##########
solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java:
##########
@@ -632,11 +685,17 @@ public Stat setData(String path, Path data, boolean
retryOnConnLoss)
public List<OpResult> multi(final Iterable<Op> ops, boolean retryOnConnLoss)
throws InterruptedException, KeeperException {
+ List<OpResult> result = null;
if (retryOnConnLoss) {
- return zkCmdExecutor.retryOperation(() -> keeper.multi(ops));
+ result = zkCmdExecutor.retryOperation(() -> keeper.multi(ops));
} else {
- return keeper.multi(ops);
+ result = keeper.multi(ops);
+ }
+ metrics.multiOps.increment();
Review Comment:
yeah, this is just counting once for a batch of operation. I'm not sure if
we should make this more expensive (yet) by reading each individual operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
