gerlowskija commented on PR #975:
URL: https://github.com/apache/solr/pull/975#issuecomment-1218414038
> can we get more javadoc on the newly introduced methods and interfaces so
that folks coming in later will better understand the shape and relationship
between everything?
Good idea; I've added some already but will add more over the next day or
two.
> Also, I saw a bunch of logging added that looks like it should probably be
debug rather than info, but I didn't bother commenting on it individually
because this is still a draft and I'm not sure how much you need it for working
out control flow at this point.
I intend to get rid of most of that logging as this gets closer to
committing. As you guessed, most of it is just leftover "personal debugging" I
did while still trying to understand control flow and lifecycle. No intention
of committing without removing that stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
