dsmiley commented on code in PR #943:
URL: https://github.com/apache/solr/pull/943#discussion_r952713889
##########
solr/solrj/build.gradle:
##########
@@ -50,20 +41,16 @@ dependencies {
implementation 'org.apache.httpcomponents:httpclient'
implementation 'org.apache.httpcomponents:httpcore'
- implementation('org.apache.zookeeper:zookeeper', {
- exclude group: "org.apache.yetus", module: "audience-annotations"
- exclude group: "log4j", module: "log4j"
- exclude group: "org.slf4j", module: "slf4j-log4j12"
- })
- implementation ('org.apache.zookeeper:zookeeper-jute') {
- exclude group: 'org.apache.yetus', module: 'audience-annotations'
- }
-
testImplementation project(':solr:test-framework')
testImplementation project(':solr:core')
testImplementation project(':solr:solrj')
testRuntimeOnly project(':solr:modules:sql')
+ // ideally ZK centric tests move to solrj-zookeeper but sometimes we depend
on ZK here anyway
+ testImplementation project(':solr:solrj-zookeeper')
+ testImplementation 'org.apache.zookeeper:zookeeper'
+ permitTestUnusedDeclared 'org.apache.zookeeper:zookeeper'
Review Comment:
@risdenk recently added a plugin to our Gradle build that demands we declare
all dependencies of a compile time nature, even transitives. This obviously
adds additional lines across our build to maintain. I wish it was smarter, for
example, don't do this for Gradle's rather unique "api". And it has bugs where
we have to add "permitBlahBlahBlah" where it shouldn't be necessary ideally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
