David Smiley created SOLR-16368:
-----------------------------------
Summary: Refactoring: Use SolrClient type instead of overly
specific subclasses
Key: SOLR-16368
URL: https://issues.apache.org/jira/browse/SOLR-16368
Project: Solr
Issue Type: Improvement
Security Level: Public (Default Security Level. Issues are Public)
Reporter: David Smiley
Assignee: Eric Pugh
There are many references to a specific SolrClient subclass that could simply
refer to SolrClient generally, or perhaps CloudSolrClient. This impedes
switching/migrating to different SolrClient implementations. A similar
example: we know it's a bad practice to declare a List as ArrayList even when
it is one; the idea here with SolrClient is the same.
And furthermore, often times "var solrClient = ..." (or even "var solr = ...")
is totally adequate in the Solr codebase within a method because the variable
name adequately communicates the type. These sorts of changes should happen
first, and then weaken type references in APIs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
