dsmiley commented on PR #994: URL: https://github.com/apache/solr/pull/994#issuecomment-1236358574
ConfigNode (which I've never heard of until today) is just an interface; I don't see SAX in there. I do see DOMConfigNode which this PR is using, so DOM is still used (not SAX); right? BTW I have no complains of DOM really; I'm just trying to reconcile what you said vs what your PR here does. Your PR leaves in place the use of XmlConfigFile for parsing elevate.xml. I like that #962 does away with that and uses SafeXMLParsing to produce the DOM `Document`. It'd be nice if `XmlConfigFile` could ultimately just go away. Maybe DOMConfigNode could/should be incorporated into this approach as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
