dsmiley commented on code in PR #962:
URL: https://github.com/apache/solr/pull/962#discussion_r963878466
##########
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java:
##########
@@ -413,17 +414,16 @@ private ElevationProvider loadElevationProvider(SolrCore
core) throws Exception
* @throws RuntimeException If the config does not provide an XML content of
the expected format
* (either {@link RuntimeException} or {@link
org.apache.solr.common.SolrException}).
*/
- protected ElevationProvider loadElevationProvider(XmlConfigFile config) {
+ protected ElevationProvider loadElevationProvider(Document doc) {
Map<ElevatingQuery, ElevationBuilder> elevationBuilderMap = new
LinkedHashMap<>();
+ NodeList nodes = doc.getDocumentElement().getElementsByTagName("query");
Review Comment:
Check that the document element has the name we expect "elevate"; otherwise
maybe the wrong XML file was given and the user would be confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
