gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r969831939
########## solr/core/src/java/org/apache/solr/jersey/SolrJerseyResponse.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.jersey; + +import com.fasterxml.jackson.annotation.JsonProperty; + +/** + * Base response-body POJO to be used by Jersey resources. + * + * <p>Contains fields common to all Solr API responses, particularly the 'responseHeader' and + * 'error' fields. + */ +public class SolrJerseyResponse implements JacksonReflectMapWriter { + + @JsonProperty("responseHeader") + public ResponseHeader responseHeader = new ResponseHeader(); + + @JsonProperty("error") + public ErrorInfo error; + + public static class ResponseHeader implements JacksonReflectMapWriter { Review Comment: I just added some "additional properties" support, making use of the JsonAnyGetter/JsonAnySetter annotation pair described in the link we discussed above. Jackson is able to use those annotations natively. Also needed a few changes to `Utils.reflectWrite` to actually get this working for XML, javabin, etc. Which isn't ideal, but is a reality of the way our MapWriter/ResponseWriter stuff works today. We already depend on Jackson on the server-side, and it supports other formats - I wonder if we couldn't just use it for XML, etc. at some point in the future. But that's of course a large and very different task. Just thinking aloud here I guess... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
