[
https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603803#comment-17603803
]
Kevin Risden edited comment on SOLR-16347 at 9/13/22 10:41 PM:
---------------------------------------------------------------
FYI I haven't looked at how/why but this change introduced a few new "warnings":
{code:java}
./gradlew check -x test
...
> Task :solr:core:analyzeClassesDependencies
Dependency analysis found issues.
unusedDeclaredArtifacts
- org.apache.lucene:lucene-backward-codecs:9.3.0@jar
- org.glassfish.jersey.containers:jersey-container-jetty-http:2.35@jar
- org.glassfish.jersey.inject:jersey-hk2:2.35@jar
- org.glassfish.jersey.media:jersey-media-json-jackson:2.35@jar
> Task :solr:core:analyzeTestClassesDependencies
Dependency analysis found issues.
unusedDeclaredArtifacts
-
org.glassfish.jersey.test-framework.providers:jersey-test-framework-provider-grizzly2:2.35@jar
...
{code}
There are a few other existing ones and
org.apache.lucene:lucene-backward-codecs:9.3.0@jar existed previously, but the
jersey ones are new. I wonder if its possible to clean these up (there are ways
to suppress in gradle) or remove them if they are actually unused.
On a separate note I'm going to look at upgrading the analyze plugin to see if
it cleans up spotbugs and a few others that have been a problem in the past -
https://github.com/gradle-dependency-analyze/gradle-dependency-analyze/releases
was (Author: risdenk):
FYI I haven't looked at how/why but this change introduced a few new "warnings":
{code:java}
./gradlew check -x test
...
> Task :solr:core:analyzeClassesDependencies
Dependency analysis found issues.
unusedDeclaredArtifacts
- org.apache.lucene:lucene-backward-codecs:9.3.0@jar
- org.glassfish.jersey.containers:jersey-container-jetty-http:2.35@jar
- org.glassfish.jersey.inject:jersey-hk2:2.35@jar
- org.glassfish.jersey.media:jersey-media-json-jackson:2.35@jar
> Task :solr:core:analyzeTestClassesDependencies
Dependency analysis found issues.
unusedDeclaredArtifacts
-
org.glassfish.jersey.test-framework.providers:jersey-test-framework-provider-grizzly2:2.35@jar
...
{code}
There are a few other existing ones and
org.apache.lucene:lucene-backward-codecs:9.3.0@jar existed previously, but the
jersey ones are new. I wonder if its possible to clean these up (there are ways
to suppress in gradle) or remove them if they are actually unused.
> Add JAX-RS integration for defining v2 APIs
> -------------------------------------------
>
> Key: SOLR-16347
> URL: https://issues.apache.org/jira/browse/SOLR-16347
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: v2 API
> Affects Versions: main (10.0)
> Reporter: Jason Gerlowski
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> SOLR-15182 rewrote our v2 APIs to use annotations using an existing
> (in-house) framework. But continuing to use a homegrown framework is less
> than ideal for a few reasons:
> # Our in-house framework doesn't integrate with 3rd-party tooling like
> OpenAPI.
> # It gives us less functionality than many off-the-shelf frameworks, at a
> higher maintenance cost.
> # The current framework is less explicit about API inputs and outputs than
> many off-the-shelf alternatives, making code less clear and readable for
> developers.
> (For more on the pros/cons and for different evaluations on the tradeoff
> here, see
> [this|https://lists.apache.org/thread/6wx2vzfnmfgkw03b7s450zfp7yhrlz8f]
> long-running dev@ thread.)
> The work done by SOLR-15182 makes the jump to JAX-RS reasonably
> straightforward on an individual API basis: once the framework is in place
> switching a given API to JAX-RS is mostly a matter of swapping out our
> homegrown annotations for those recognized by JAX-RS and changing API method
> signatures to better represent the API inputs/outputs.
> We should integrate Jersey or a similar JAX-RS implementation and start
> cutting over v2 APIs to this new mode of definition.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
