dsmiley commented on code in PR #1012:
URL: https://github.com/apache/solr/pull/1012#discussion_r972096194
##########
solr/core/src/java/org/apache/solr/util/ExportTool.java:
##########
@@ -490,7 +491,7 @@ class CoreHandler {
}
boolean exportDocsFromCore() throws IOException, SolrServerException {
- HttpSolrClient client = new HttpSolrClient.Builder(baseurl).build();
+ SolrClient client = new HttpSolrClient.Builder(baseurl).build();
Review Comment:
Up to you, but if you can easily also do try-with-resources pattern as well,
that'd be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
