risdenk commented on code in PR #1026:
URL: https://github.com/apache/solr/pull/1026#discussion_r975504086
##########
solr/core/src/java/org/apache/solr/search/grouping/distributed/responseprocessor/SearchGroupShardResponseProcessor.java:
##########
@@ -108,9 +114,11 @@ public void process(ResponseBuilder rb, ShardRequest
shardRequest) {
.put(SolrQueryResponse.RESPONSE_HEADER_PARTIAL_RESULTS_KEY,
Boolean.TRUE);
continue; // continue if there was an error and we're tolerant.
}
- maxElapsedTime = (int) Math.max(maxElapsedTime,
srsp.getSolrResponse().getElapsedTime());
- NamedList<NamedList<?>> firstPhaseResult =
- (NamedList<NamedList<?>>)
srsp.getSolrResponse().getResponse().get("firstPhase");
+ maxElapsedTime = (int) Math.max(maxElapsedTime,
solrResponse.getElapsedTime());
+ NamedList<NamedList<?>> firstPhaseResult =
getFirstPhaseFromShardResponse(rb, srsp);
+ if (firstPhaseResult == null) {
Review Comment:
Thanks added util class to help with these. I addressed a bunch of other
places that follow the same pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
