magibney opened a new pull request, #1028: URL: https://github.com/apache/solr/pull/1028
See: [SOLR-16219](https://issues.apache.org/jira/browse/SOLR-16219) `protected` access modifier behaves differently across different classloaders, so in the common-case deployment of certain optional modules in Solr (e.g., analysis-extras), access that works fine in unit tests can fail in real deployment. This PR fixes one such issue (introduced in https://github.com/apache/solr/commit/9e4376738e38559aeba5d62ee7b54dc68f6b9004), and adds an integration test to prevent regression. Ideally it would be nice to have a more systematic way to test deployment of modules in a different classloader contexts, but this should suffice to address the immediate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
