risdenk commented on code in PR #1024:
URL: https://github.com/apache/solr/pull/1024#discussion_r976562154
##########
solr/core/src/java/org/apache/solr/util/SolrVersion.java:
##########
@@ -32,7 +32,7 @@ public final class SolrVersion implements
Comparable<SolrVersion> {
private final Version version;
// This static variable should be bumped for each release
- private static final String LATEST_STRING = "10.0.0";
+ public static final String LATEST_STRING = "10.0.0";
/** This instance represents the current (latest) version of Solr. */
public static final SolrVersion LATEST = SolrVersion.valueOf(LATEST_STRING);
Review Comment:
Would it be better to just use `LATEST` since its already public? I know it
would be converting back to string potentially but keeps the encapsulation that
was here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
