gerlowskija opened a new pull request, #1035:
URL: https://github.com/apache/solr/pull/1035

   
   
   
   # Description
   
   Historically, V2HttpCall has determined whether a given API is an "admin" 
request or a "core" request based on its path. Paths containing a 
core/collection name are "core" requests, all others are considered "admin" 
requests. V2HttpCall figures out what request-type its dealing with, and then 
knows which PluginBag to look for an Api in. This works because the original v2 
API was designed with this heuristic in mind: it's one of the main reasons that 
some paths (e.g. /collections) have so many sub-commands.
   
   But it doesn't work with the more REST-ful paths we hope to use in our v2 
API modernization effort.
   
   # Solution
   
   This PR takes a sort of "guess and check" approach, where we try serving 
ambiguous requests from multiple Jersey apps in series, stopping at the first 
one that doesn't spit out a quick `NotFoundException`.
   
   # Tests
   
   Manual testing.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to