epugh commented on code in PR #1037:
URL: https://github.com/apache/solr/pull/1037#discussion_r977566523
##########
solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java:
##########
@@ -819,7 +819,7 @@ public void testFailedParseMixedBoolean() throws Exception {
if (longVal == o) {
foundLong = true;
} else {
- assertThat(o, IS_STRING);
+ assertTrue(o instanceof String);
Review Comment:
I suspect you are trying to minimize any refactoring... However, could you
eliminate IS_STRING? A quick glance makes me think it is only used in
asserts...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
