[
https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608397#comment-17608397
]
ASF subversion and git services commented on SOLR-16427:
--------------------------------------------------------
Commit 83de120de950fee3876a9e3a6b344b403630ae06 in solr's branch
refs/heads/main from Kevin Risden
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=83de120de95 ]
SOLR-16427: Evaluate and fix errorprone rules (#1037)
Enables the following errorprone rules:
* `ArrayEquals`
* `ArrayHashCode`
* `ArrayToString`
* `CollectionUndefinedEquality`
* `EqualsIncompatibleType`
* `FormatString`
* `UndefinedEquals`
Most of the fixes are straight forward - use `.equals` and `Objects.equals`
where appropriate. Used `contentEquals` for char sequences. Make sure to
compare `Instant` instead of just `Date`. Ensure proper string format number of
arguments. Make sure to use proper Array methods for `hashCode` and `toString`
> Evaluate and fix errorprone rules
> ---------------------------------
>
> Key: SOLR-16427
> URL: https://issues.apache.org/jira/browse/SOLR-16427
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Errorprone has many rules and there are a bunch that are disabled in Solr.
> Some make sense to leave disabled. Others are just disabled because they
> weren't evaluated.
> See
> https://github.com/apache/solr/blob/main/gradle/validation/error-prone.gradle
> This was previously done for some rules in SOLR-15908 and SOLR-15613. This
> relates to SOLR-16364
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
