epugh commented on code in PR #1012:
URL: https://github.com/apache/solr/pull/1012#discussion_r992714597
##########
solr/solrj/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java:
##########
@@ -100,10 +100,11 @@ public synchronized CloudSolrClient
getCloudSolrClient(String zkHost) {
}
@Deprecated(since = "9.0")
- public synchronized HttpSolrClient getHttpSolrClient(String host) {
- HttpSolrClient client;
+ // is this really deprecated? what if it's getSolrClient? It COULD be!
Review Comment:
i think this is a good follow up candidate... I updated the host -->
baseUrl, but I think we also should undeprecate these methods... in another
issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
