[
https://issues.apache.org/jira/browse/SOLR-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617928#comment-17617928
]
Jason Gerlowski edited comment on SOLR-16462 at 10/14/22 7:34 PM:
------------------------------------------------------------------
Does this ticket target the collection-level snapshot APIs? (e.g.
/admin/collections?action=CREATESNAPSHOT) Or their core-level counterparts?
(/admin/cores?action=CREATESNAPSHOT). Or both?
Some months back I put together a
[spreadsheet|https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?usp=sharing]
to inventory Solr's v1 APIs, their v2 equivalents, and propose some
improvements to the v2 APIs. Those proposed v2 improvements included
suggestions for what the "missing" v2 APIs should look like when they get
added, and those proposed changes got some tenative +1's from the mailing list.
Nothing is set in stone of course, but I put a good bit of thought into it, so
it's at least a good start to figure out what the v2 snapshot APIs should look
like.
For the snapshot APIs in particular, the syntax I proposed at the time was:
* collection CREATESNAPSHOT - POST
/api/collections/collName/snapshots/snapshotName
* collection LISTSNAPSHOT - GET /api/collections/collName/snapshots
* collection DELETESNAPSHOT - DELETE
/api/collections/collName/snapshots/snapshotName
* core CREATESNAPSHOT - POST /api/cores/coreName/snapshots/snapshotName
* core LISTSNAPSHOT - GET /api/cores/coreName/snapshots
* core DELETESNAPSHOT - DELETE /api/cores/coreName/snapshots/snapshotName
A few other pointers that might be helpful, especially for newcomers:
* The v1 logic for this API lives in CollectionsHandler (for the
collection-level APIs) and CoreAdminHandler (for the core-level APIs).
* [Some discussion of how APIs work in
Solr|https://issues.apache.org/jira/browse/SOLR-15737?focusedCommentId=17565076&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17565076]
(Particularly the "APIs in Solr" section.)
* [A step-by-step guide to creating APIs using the preferred v2 API
framework|https://issues.apache.org/jira/browse/SOLR-15737?focusedCommentId=17617923&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17617923]
* [A recent PR that adds a v2 API, as an
example|https://github.com/apache/solr/pull/1061/files]
was (Author: gerlowskija):
Does this ticket target the collection-level snapshot APIs? (e.g.
/admin/collections?action=CREATESNAPSHOT) Or their core-level counterparts?
(/admin/cores?action=CREATESNAPSHOT). Or both?
Some months back I put together a
[spreadsheet|https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?usp=sharing]
to inventory Solr's v1 APIs, their v2 equivalents, and propose some
improvements to the v2 APIs. Those proposed v2 improvements included
suggestions for what the "missing" v2 APIs should look like when they get
added, and those proposed changes got some tenative +1's from the mailing list.
Nothing is set in stone of course, but I put a good bit of thought into it, so
it's at least a good start to figure out what the v2 snapshot APIs should look
like.
For the snapshot APIs in particular, the syntax I proposed at the time was:
* collection CREATESNAPSHOT - POST
/api/collections/collName/snapshots/snapshotName
* collection LISTSNAPSHOT - GET /api/collections/collName/snapshots
* collection DELETESNAPSHOT - DELETE
/api/collections/collName/snapshots/snapshotName
* core CREATESNAPSHOT - POST /api/cores/coreName/snapshots/snapshotName
* core LISTSNAPSHOT - GET /api/cores/coreName/snapshots
* core DELETESNAPSHOT - DELETE /api/cores/coreName/snapshots/snapshotName
A few other pointers that might be helpful, especially for newcomers:
* The v1 logic for this API lives in CollectionsHandler (for the
collection-level APIs) and CoreAdminHandler (for the core-level APIs).
* Some discussion of how APIs work in Solr
* A step-by-step guide to creating APIs using the preferred v2 API framework
* [A recent PR that adds a v2 API, as an
example|https://github.com/apache/solr/pull/1061/files]
> Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and
> 'DELETESNAPSHOT'
> --------------------------------------------------------------------------------
>
> Key: SOLR-16462
> URL: https://issues.apache.org/jira/browse/SOLR-16462
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
> Affects Versions: 9.1
> Reporter: Sanjay
> Priority: Major
>
> Snapshot API has no v2 equivalent. This ticket is to track changes made to
> the Solr to add v2 equivalent of 'CREATESNAPSHOT', 'LISTSNAPSHOT' and
> 'DELETESNAPSHOT' api.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
