dsmiley commented on PR #1079: URL: https://github.com/apache/solr/pull/1079#issuecomment-1279893347
Reacting to the description: A test that is using EmbeddedSolrServer that doesn't need it probably doesn't need Solr at all; maybe it's a pure unit test of some method or component by itself. As for AbstractEmbeddedSolrServerTestCase... hmmm... I'm not sure if I like it or not. I Reacting to the code: I see you switched a test from using EmbeddedSolrServer to using Jetty :-). This is more heavy weight and now is possibly needlessly using HTTP that the test formerly didn't need. EmbeddedSolrServer is pretty awesome IMO; it wraps the essential guts of Solr (a CoreContainer & SolrCore). It wouldn't hurt for you to take a look at a project to do a make-over on most of our tests: https://issues.apache.org/jira/browse/SOLR-11872 This will be underway this winter with an Outreachy intern and me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
