uschindler commented on PR #1090: URL: https://github.com/apache/solr/pull/1090#issuecomment-1285084858
Hi Jan, > I made the workaround conditional on java version. Tested `bin/solr` but did not get a chance to test `bin\solr.cmd`, perhaps you can test it Uwe? > > Start Solr on JDK11 and JDK17 and see that the start script prints "...Enabled workaround for [SOLR-16463](https://issues.apache.org/jira/browse/SOLR-16463)" on v17, and that you find the `-XX:CompileCommand` flag in the args list http://localhost:8983/solr/admin/info/system Hi, your code works, but Solr does not start for me because there is one escaping missing for the GC LOG. So there's another bug in the startup script. If you like please fix it now, it was introduced by @elyograg recently (SOLR-8803, 0a334bda7ea40d5c11195fa5ce33d16c21d0504e). The log fdirectory needs to be escaped, otherwise whitespace in it breaks the whole startup script. I will commit a fix in main branch (and 9.x, also checking 9.1). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
