joel-bernstein commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1285456616
Before I close this PR and start to work on a solrj-streaming PR lets be sure we don't want this to be server module. The original streaming classes were designed to be a Java API using the decorator pattern to layer on new behaviors. This fit pretty well with the Solrj library which is Java based. So it was placed there. When streaming expressions came around it became easy to support complex expressions that simply are not practical with the Java API. The /stream handler became the focal point which moved things towards are server side model. At this point I consider Streaming Expressions a server side tool. My suggestion is that we make it a server side module and we can add Solrj support for sending a Streaming Expression to the stream handler. The only reason I see to keep it a client side tool is to support existing clients that are using the Java API. Which may be reason enough. One compromise would be to leave a small subset of TupleStream implementations in Solrj. Then move all the rest of the classes to a server side module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
