dsmiley commented on code in PR #585:
URL: https://github.com/apache/solr/pull/585#discussion_r1002878363


##########
solr/core/src/java/org/apache/solr/util/StartupLoggingUtils.java:
##########
@@ -50,7 +50,7 @@ public static void checkLogDir() {
   }
 
   public static String getLoggerImplStr() { // nowarn
-    return binder.getLoggerFactoryClassStr();
+    return loggerFactory.getClass().toString().replace("class ", "");

Review Comment:
   ```suggestion
       return loggerFactory.getClass().getName();
   ```



##########
solr/core/src/java/org/apache/solr/logging/LogWatcher.java:
##########
@@ -150,7 +149,7 @@ private static LogWatcher<?> createWatcher(LogWatcherConfig 
config, SolrResource
     String slf4jImpl;
 
     try {
-      slf4jImpl = StaticLoggerBinder.getSingleton().getLoggerFactoryClassStr();
+      slf4jImpl = 
LoggerFactory.getILoggerFactory().getClass().toString().replace("class ", "");

Review Comment:
   ```suggestion
         slf4jImpl = LoggerFactory.getILoggerFactory().getClass().getName();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to