risdenk commented on PR #1121: URL: https://github.com/apache/solr/pull/1121#issuecomment-1290875313
> Can we please consider not using String.format here at all? String.format is useful when there is non-trivial formatting. I don't think we should use String.format when a trivial String concatenation can do the job. I don't understand why some people reach for more complex tools like this when the language itself is adequate. hmm good point. I mistakenly hit the merge button on this trying to merge the commons-text one. I can follow up w/ this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
