risdenk commented on code in PR #1129:
URL: https://github.com/apache/solr/pull/1129#discussion_r1005095748


##########
solr/core/src/java/org/apache/solr/cloud/OverseerNodePrioritizer.java:
##########
@@ -133,6 +135,23 @@ public synchronized void prioritizeOverseerNodes(String 
overseerId) throws Excep
     
overseer.sendQuitToOverseer(OverseerTaskProcessor.getLeaderId(zkStateReader.getZkClient()));
   }
 
+  private void invokeOverseerOpWithRetries(String electionNode, String op, int 
retryCount) {
+    boolean successful = false;
+    for (int i = 0; i < retryCount && !successful; i++) {
+      try {
+        invokeOverseerOp(electionNode, op);
+        successful = true;
+      } catch (SolrException e) {
+        if (i < retryCount - 1) {

Review Comment:
   it looks like maybe a sleep was added then removed? not sure at least now 
there is no sleep?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to