HoustonPutman commented on PR #1125: URL: https://github.com/apache/solr/pull/1125#issuecomment-1292141008
> Does this remove gradle signing? It does not, it removes the ability to use gradle signing via the release wizard. The `ORG_GRADLE_PROJECT_signingPassword` variable which is used to pass the password for the gradle signing method (from `buildAndPushRelease.py`) only works with the [`useInMemoryPgpKeys` function](https://docs.gradle.org/current/userguide/signing_plugin.html#sec:in-memory-keys) which we don't use. This means that the only way the python script could pass the passphrase to gradle is via a `-P` which isn't great. So much easier to just make sure release managers use the gpg method, and make sure the password is pre-cached for the gradle command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
