gerlowskija commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1006098487
##########
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java:
##########
@@ -452,6 +454,11 @@ void call() throws Exception {
}
}
+ @Override
Review Comment:
> Yes it's backup API from the ReplicationHandler but I assumed from the new
proposed v2 format that it goes into CoreAdminHandler as it starts with /cores
Ah, I see!
The short answer here is that there's no 1:1 mapping between the v2 path and
the RequestHandler that the functionality originally came from. Or vice versa.
There are v1 RequestHandlers (e.g. CollectionsHandler) whose functionality is
going to be split across a handful of different paths. And there are v2 paths
whose functionality originally came from a number of different RequestHandlers.
So in terms of registering each v2 API, the convention I've been following
has been to register them on whatever RequestHandler the functionality
originally came from, regardless of the v2 path.
Great observation though - I'll try to clarify this in the "step-by-step"
writeup I put in JIRA.
> I will not have access to the SolrParams that we configure in
solrconfig.xml for ReplicationHandler
You've got a really keen eye for all the stuff that doesn't work yet! 😛
You're right - we don't currently have a way to get those requestHandler-level
settings forwarded to the corresponding v2 API. Definitely something I hope to
fix sooner rather than later. I spiked out a solution awhile back but it was
pretty hacky. If you're interested in digging into that some, definitely lmk
and we can get a JIRA filed and work on it together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
