[ 
https://issues.apache.org/jira/browse/SOLR-16499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624776#comment-17624776
 ] 

Noble Paul commented on SOLR-16499:
-----------------------------------

I guess it should be a mistake that these params are omitted. We should pass 
these parameters on to overseer

> REPLACENODE API doesn't obey 'parallel', 'timeout' params
> ---------------------------------------------------------
>
>                 Key: SOLR-16499
>                 URL: https://issues.apache.org/jira/browse/SOLR-16499
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: main (10.0)
>            Reporter: Jason Gerlowski
>            Priority: Major
>
> The ref-guide docs for the REPLACENODE collection-admin API mention two 
> parameters ("parallel", and "timeout") that are used by the processing in 
> ReplaceNodeCmd, but are never passed through by CollectionsHandler as far as 
> I can tell.
> It looks like CollectionsHandler passed through "parallel" initially (see 
> commit ae60c7, which added the REPLACENODE command), up until c9cf57 (of 
> SOLR-11068).  It might've been removed intentionally, but there's no 
> discussion on the ticket to suggest one way or another.
> "timeout" on the other hand looks like it was never passed through to 
> ReplaceNodeCmd, even on the initial introduction of REPLACENODE, unless I'm 
> missing something.
> We should decide whether these parameters still make sense.  If they do, we 
> should add the necessary plumbing to CollectionsHandler.  If they don't, we 
> should remove them from the ref-guide and cleanup ReplaceNodeCmd to not look 
> for them.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to