cpoerschke commented on code in PR #1141:
URL: https://github.com/apache/solr/pull/1141#discussion_r1007227616
##########
solr/core/src/java/org/apache/solr/update/DocumentBuilder.java:
##########
@@ -336,16 +336,17 @@ private static boolean addCopyFields(
+ ": "
+ originalFieldValue);
}
+ Object fieldValue = originalFieldValue;
Review Comment:
Perhaps `final Object originalFieldValue` could be used on the method
signature to show the intention that it is not to be assigned to (any more).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]