risdenk commented on code in PR #1108:
URL: https://github.com/apache/solr/pull/1108#discussion_r1008090130
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java:
##########
@@ -193,7 +194,9 @@ public boolean split(ClusterState clusterState, ZkNodeProps
message, NamedList<O
RTimerTree t;
if (ccc.getCoreContainer().getNodeConfig().getMetricsConfig().isEnabled())
{
// check disk space for shard split
- if
(Boolean.parseBoolean(System.getProperty(SHARDSPLIT_CHECKDISKSPACE_ENABLED,
"true"))) {
+ if (!message.getBool(
+ SKIP_FREE_SPACE_CHECK,
+
!Boolean.parseBoolean(System.getProperty(SHARDSPLIT_CHECKDISKSPACE_ENABLED,
"true")))) {
Review Comment:
🎉 sorry @gezapeti for the extra work. I was just going through the
lucene-solr PRs and noticed this was hanging out there. Didn't realize it was
addressed a different way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
