risdenk commented on code in PR #1146:
URL: https://github.com/apache/solr/pull/1146#discussion_r1008366409
##########
solr/core/src/java/org/apache/solr/search/ExtendedQuery.java:
##########
@@ -25,27 +25,23 @@
*/
public interface ExtendedQuery {
/** Should this query be cached in the query cache or filter cache. */
- public boolean getCache();
-
- public void setCache(boolean cache);
+ boolean getCache();
/**
* Returns the cost of this query, used to order checking of filters that
are not cached. If
* getCache()==false && getCost()>=100 && this instanceof
PostFilter, then the
* PostFilter interface will be used for filtering. Otherwise, for smaller
costs, this cost will
* be used for {@link TwoPhaseIterator#matchCost()}.
*/
- public int getCost();
-
- public void setCost(int cost);
Review Comment:
Public API change
##########
solr/core/src/java/org/apache/solr/search/ExtendedQuery.java:
##########
@@ -25,27 +25,23 @@
*/
public interface ExtendedQuery {
/** Should this query be cached in the query cache or filter cache. */
- public boolean getCache();
-
- public void setCache(boolean cache);
Review Comment:
Public API change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
