[
https://issues.apache.org/jira/browse/SOLR-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626672#comment-17626672
]
Jason Gerlowski commented on SOLR-16462:
----------------------------------------
bq. the developer would have to know to call that method [...] be responsible
for returning early. [etc]
I agree. I think handling the async stuff "higher" in the stack would be
cleaner, and I think the approach you described sounds totally reasonable.
But...it feels out of scope to me for this ticket? Stuff that adds an executor
or threads to Solr tends to get a decent amount of scrutiny (as it should).
Additionally, Solr has a handful of APIs that offer async processing, but
they're kindof disjointed: both in the interfaces they expose and in how they
work under the covers (i.e. CollectionsHandler does async very differently than
CoreAdminHandler, etc.). If we're refactoring the async processing, I'd want
to do it in a uniform way for all of the APIs affected.
Does that sound reasonable? If you're still interested in pursuing I'd be
happy to work with you on it; we'd just have to be a different JIRA to get the
ball rolling?
bq. With either approach, where would the "async" handling logic happen?
If we're deferring the ideal solution (at least for a bit), I think your
initial idea of having some processing logic live in a base API class sounds
great. There's precedent for that in the (poorly named) {{AdminAPIBase}} class
we created for some of the CollectionsHandler endpoints - we could do something
similar here.
> Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and
> 'DELETESNAPSHOT' (core level)
> ----------------------------------------------------------------------------------------------
>
> Key: SOLR-16462
> URL: https://issues.apache.org/jira/browse/SOLR-16462
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
> Affects Versions: 9.1
> Reporter: Sanjay Dutt
> Priority: Major
> Labels: V2, newdev
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Snapshot API has no v2 equivalent. This ticket is to track changes made to
> the Solr to add v2 equivalent of 'CREATESNAPSHOT', 'LISTSNAPSHOT' and
> 'DELETESNAPSHOT' api.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
