HoustonPutman commented on PR #485:
URL: https://github.com/apache/solr-operator/pull/485#issuecomment-1298587121

   But your PR is quite close, you've done a good job!
   
   You would have had two steps left:
   - Actually set the projected volume on the pods in the controller (you have 
just created a CRD entry and test, the test fails because you aren't actually 
using the information from the CRD to set the Pod).
     - 
https://github.com/apache/solr-operator/blob/main/controllers/util/solr_util.go#L237
     - 
https://github.com/apache/solr-operator/blob/main/controllers/util/prometheus_exporter_util.go#L158
   - Run `make prepare` to do the code/config generation and auto format 
everything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to