epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011650146
##########
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleStreamingBinaryTest.java:
##########
@@ -35,9 +34,15 @@ public class SolrExampleStreamingBinaryTest extends
SolrExampleStreamingTest {
@Override
public SolrClient createNewSolrClient() {
- ConcurrentUpdateSolrClient client = (ConcurrentUpdateSolrClient)
super.createNewSolrClient();
- client.setParser(new BinaryResponseParser());
- client.setRequestWriter(new BinaryRequestWriter());
+
+ SolrClient client =
+ new ErrorTrackingConcurrentUpdateSolrClient.Builder(getServerUrl())
+ .withQueueSize(2)
+ .withThreadCount(5)
Review Comment:
okay, now I remember.. I eliminate the `super.createNewSolrClient` partly
because it was a pattern I had never seen used elsewhere, and in
`SolrExampleStreamingTest` it looks like:
```
return new ErrorTrackingConcurrentUpdateSolrClient.Builder(getServerUrl())
.withQueueSize(2)
.withThreadCount(5)
.withResponseParser(new XMLResponseParser())
.withRequestWriter(new RequestWriter())
.build();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
