epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1014373636
##########
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##########
@@ -2562,20 +2562,20 @@ public static Object skewed(Object likely, Object
unlikely) {
* A variant of {@link
org.apache.solr.client.solrj.impl.CloudHttp2SolrClient.Builder} that will
* randomize some internal settings.
*/
- public static class CloudHttp2SolrClientBuilder extends
CloudHttp2SolrClient.Builder {
+ public static class RandomizingCloudHttp2SolrClientBuilder extends
CloudHttp2SolrClient.Builder {
Review Comment:
So, it is called from `SolrTestCaseJ4.getCloudHttp2SolrClient()`, who does
`return new RandomizingCloudHttp2SolrClientBuilder(cluster).build();`
`getCloudHttp2SolrClient()` is only ever used by one method
`CloudHttp2SolrClientBadInputTest.testDeleteByIdReportsInvalidIdLists`, who I
don't actually think cares that it might have randomization.
It appears to be a "good idea" that never went anywhere... We could move
it to that one class, or maybe look to use it in more places? Dunno.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
