Jdurham2843 commented on PR #1126: URL: https://github.com/apache/solr/pull/1126#issuecomment-1312846199
Update: 1. I added some JavaDocs to CoreAdminAPIBase and CoreSnapshotAPI. I tried to follow the same general patterns I saw in JerseyResource and in the SchemaNameAPI class. 2. I made an attempt at reusing the executor and statusMap from CoreAdminHandler in the CoreAdminAPIBase class. Instead of Injecting both separately, I moved them both into a static nested class on CoreAdminHandler and wrote some code to Inject that. Even if we decide not to use this version and instead you have a better approach, we can revert these changes. I at least wanted to give it a shot first! 3. I added the V2 squash static method to the V1 ListSnapshots operation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
