[
https://issues.apache.org/jira/browse/SOLR-16504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635466#comment-17635466
]
Bence Szabó edited comment on SOLR-16504 at 11/17/22 5:19 PM:
--------------------------------------------------------------
I understand that until there is a solution for the auth related problem for
the jetty client we can not proceed with committing a solution for the client
migration of the CLI tools. However I was working on this in the meantime and
if possible I would like a review for my changes so far - I have created a PR
for this ([https://github.com/apache/solr/pull/1182]) but it is still just a
work-in-progress thing, just it started to get bigger and bigger so I figured
that a review at a more stable point would be useful before proceeding.
I have run all the automated tests against my changes and also went ahead and
tested manually every SolrCLI scenario that came to my mind and it was all
working fine. Can somebody please have a look at it and add any comments that
would help me go in the right direction with this solution?
Thank you in advance.
was (Author: bszabo97):
I understand that until there is a solution for the auth related problem for
the jetty client we can not proceed with committing a solution for the client
migration of the CLI tools. However I was working on this in the meantime and
if possible I would like a review for my changes so far - I have created a PR
for this ([https://github.com/apache/solr/pull/1182)] but it is still just a
work-in-progress thing, just it started to get bigger and bigger so I figured
that a review at a more stable point would be useful before proceeding.
I have run all the automated tests against my changes and also went ahead and
tested manually every SolrCLI scenario that came to my mind and it was all
working fine. Can somebody please have a look at it and add any comments that
would help me go in the right direction with this solution?
Thank you in advance.
> Convert CLI tools to Jetty HTTP 2 client.
> -----------------------------------------
>
> Key: SOLR-16504
> URL: https://issues.apache.org/jira/browse/SOLR-16504
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Priority: Major
> Labels: newdev
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Affected classes: SolrCLI, ExportTool, PackageTool, SolrLogPostTool
> The aforementioned classes are in the org.apache.solr.util package and are
> CLI tools (have a main method, are executed outside the context of a Solr
> server). These should be converted to our non-legacy Solr clients based on
> Jetty HttpClient. (i.e. don't use CloudLegacySolrClient or HttpSolrClient
> which are based on Apache HttpClient).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
