epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1031485769
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java:
##########
@@ -499,10 +502,16 @@ public void testUpdate() throws Exception {
// parameter encoding
assertEquals(1, DebugServlet.parameters.get("a").length);
assertEquals("\u1234", DebugServlet.parameters.get("a")[0]);
+ }
+ try (Http2SolrClient client =
+ new Http2SolrClient.Builder(url)
+ .withRequestWriter(new RequestWriter())
+ .withResponseParser(new XMLResponseParser())
+ .build()) {
// XML response and writer
- client.setParser(new XMLResponseParser());
- client.setRequestWriter(new RequestWriter());
+ // client.setParser(new XMLResponseParser());
+ // client.setRequestWriter(new RequestWriter());
Review Comment:
and likewise, thanks for the eyes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
