[ 
https://issues.apache.org/jira/browse/SOLR-16498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640817#comment-17640817
 ] 

ASF subversion and git services commented on SOLR-16498:
--------------------------------------------------------

Commit 251136de064e7745b06be3ec3844ed86b68b3deb in solr's branch 
refs/heads/main from Joshua Ouma
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=251136de064 ]

SOLR-16498: Tests to retrieve url from SolrClient (#1149)

Reduce the casting to HttpSolrClient just to get the url out when we can 
instead access JettySolrRunner object that provides that variable.   Also 
introduced a getHttpClient() method on SolrJettyTestBase that gets the Apache 
HttpClient that we use in many tests.  

Started the process of referring to collection1 via the 
DEFAULT_TEST_COLLECTION_NAME constant.

Co-authored-by: Eric Pugh <[email protected]>

> Tests need the URL from a SolrClient; don't require legacy clients
> ------------------------------------------------------------------
>
>                 Key: SOLR-16498
>                 URL: https://issues.apache.org/jira/browse/SOLR-16498
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>            Reporter: David Smiley
>            Priority: Major
>              Labels: newdev
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> SOLR-16368 could not switch many tests away from some legacy/deprecated 
> SolrClient classes because they were either getting the URL or Apache 
> HttpClient instance out of the client.  This issue aims to solve this so that 
> our tests don't depend on a legacy client and don't depend on Apache 
> HttpClient either.  We would prefer a non-dependency approach using [Java 
> 11's new 
> HttpClient|https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/package-summary.html].
>   And we need to figure out how to get the URL from the SolrClient in a more 
> general way.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to