stillalex commented on code in PR #1107:
URL: https://github.com/apache/solr/pull/1107#discussion_r1038344272
##########
solr/core/src/java/org/apache/solr/search/QueryResultKey.java:
##########
@@ -33,16 +36,14 @@ public final class QueryResultKey implements Accountable {
final Query query;
final Sort sort;
- final SortField[] sfields;
+ final List<SortField> sfields;
Review Comment:
I think there is one missed aspect here regarding the ramBytesUsed value. it
currently will account for SortField array header and sum of entries (line 77
below). changing to List would have to update that part too. (as a side note it
is also not including 'sort' field)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
