[
https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642718#comment-17642718
]
Ishan Chattopadhyaya commented on SOLR-16347:
---------------------------------------------
bq. This is why I advocated in Slack to keep all of the discussion about this
in one place - context is super important in all of this stuff, and *it's easy
to mislead folks by innocuous, accidental omission*. Let's make this discussion
as easy to follow as possible.
Can you please specify what is it that the slack discussions contain that I'm
omitting and "mislead[ing]" anyone? The entire benchmarks are open source, I've
added reproducible steps, I've answered all your questions about methodology in
details in SOLR-16531.
bq. If entrenchment is a big part of your concern, would you feel better about
things if I held off on subsequent branch_9x JAX-RS backports until more
progress has been made on the underlying regression?
I'll be glad if the entire API refactoring effort is performant, but I see no
path or progress towards making it performant. Hence, I request that we bring
it back to our development branches once it is performant. I feel it is the
most reasonable thing to do and something that will keep all the API
refactoring effort in a single place, until it doesn't compromise performance.
Hence, I'm still -1 on this.
> Add JAX-RS integration for defining v2 APIs
> -------------------------------------------
>
> Key: SOLR-16347
> URL: https://issues.apache.org/jira/browse/SOLR-16347
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: v2 API
> Affects Versions: main (10.0)
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> SOLR-15182 rewrote our v2 APIs to use annotations using an existing
> (in-house) framework. But continuing to use a homegrown framework is less
> than ideal for a few reasons:
> # Our in-house framework doesn't integrate with 3rd-party tooling like
> OpenAPI.
> # It gives us less functionality than many off-the-shelf frameworks, at a
> higher maintenance cost.
> # The current framework is less explicit about API inputs and outputs than
> many off-the-shelf alternatives, making code less clear and readable for
> developers.
> (For more on the pros/cons and for different evaluations on the tradeoff
> here, see
> [this|https://lists.apache.org/thread/6wx2vzfnmfgkw03b7s450zfp7yhrlz8f]
> long-running dev@ thread.)
> The work done by SOLR-15182 makes the jump to JAX-RS reasonably
> straightforward on an individual API basis: once the framework is in place
> switching a given API to JAX-RS is mostly a matter of swapping out our
> homegrown annotations for those recognized by JAX-RS and changing API method
> signatures to better represent the API inputs/outputs.
> We should integrate Jersey or a similar JAX-RS implementation and start
> cutting over v2 APIs to this new mode of definition.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
