dsmiley commented on code in PR #1048:
URL: https://github.com/apache/solr/pull/1048#discussion_r1040413560
##########
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java:
##########
@@ -1205,7 +1205,6 @@ private void doDefensiveChecks(DistribPhase phase) {
}
if ((isLeader && !localIsLeader) || (isSubShardLeader && !localIsLeader)) {
- log.error("ClusterState says we are the leader, but locally we don't
think so");
Review Comment:
commenting this seems to be out of scope
##########
solr/CHANGES.txt:
##########
@@ -41,6 +41,8 @@ New Features
* SOLR-16409: Admin UI - Expose all highlighting parameters in the Query UI
(Jeanie Lam via Eric Pugh)
+* SOLR-16438: Support optional split.setPreferredLeaders prop in shard split
command. (Bruno Roustant)
Review Comment:
I don't see Solr Ref Guide changes
##########
solr/CHANGES.txt:
##########
@@ -41,6 +41,8 @@ New Features
* SOLR-16409: Admin UI - Expose all highlighting parameters in the Query UI
(Jeanie Lam via Eric Pugh)
+* SOLR-16438: Support optional split.setPreferredLeaders prop in shard split
command. (Bruno Roustant)
Review Comment:
People debate this sort of thing but I think of this as an improvement to a
feature and not a new feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
