[ 
https://issues.apache.org/jira/browse/SOLR-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644021#comment-17644021
 ] 

ASF subversion and git services commented on SOLR-10459:
--------------------------------------------------------

Commit 8e00c9c181a54f1ce456221073ed2665a1c6f34e in solr's branch 
refs/heads/main from Eric Pugh
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=8e00c9c181a ]

SOLR-8975: Use Builder Pattern with all Solr Clients where possible (#1211)

Introduce Builder setters for setters that exist on SolrClients for 
responseParser, requestWriter.  Deprecated these SolrClient setters 
useMultiPartPost, and followRedirects.  Update corresponding tests to use these 
changes.  Migrate to try/with resources for Solr Clients where possible in 
tests.  Closes SOLR-10455 and SOLR-10459.

> setRequestWriter should be deprecated in favor of SolrClientBuilder methods
> ---------------------------------------------------------------------------
>
>                 Key: SOLR-10459
>                 URL: https://issues.apache.org/jira/browse/SOLR-10459
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrJ
>            Reporter: Jason Gerlowski
>            Priority: Minor
>             Fix For: 7.0
>
>
> Now that builders are in place for {{SolrClients}}, the setters used in each 
> {{SolrClient}} can be deprecated, and their functionality moved over to the 
> Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice 
> to have all the knobs, and levers used to tweak {{SolrClient}}s available in 
> a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are 
> mutable. Using some {{SolrClient}} setters can result in erratic and "trappy" 
> behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the {{setRequestWriter}} 
> setter on all {{SolrClient}} implementations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to