epugh commented on PR #1220: URL: https://github.com/apache/solr/pull/1220#issuecomment-1344483969
> You added to the Builder but never consumed it! Do this in CloudSolrClient which is the base of the new & old impls. > > You said we do not _use_ this property but I believe you mean we do not _set_ this property. It is used/retrieved in CloudSolrClient. I was about to post a screenshot showing that this value was never used, and finally found it in a method `shouldRetry`. I duplicated the setting so if you use the builder you get it, if you don't you still get it. Maybe when we remove the deprecated methods, these defaults will just livei n the builder? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
