risdenk commented on code in PR #1237:
URL: https://github.com/apache/solr/pull/1237#discussion_r1047549409
##########
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##########
@@ -326,6 +326,9 @@ protected ResponseBuilder newResponseBuilder(
@Override
public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp)
throws Exception {
+ if (log.isInfoEnabled()) {
+ log.info("Start Search Query: {}", req.getParamString());
+ }
Review Comment:
> it's important for our use case as queries can sometimes be totally stuck
hence timeout wouldn't get printed.
yea I totally understand that. Its always nice to have logging but at the
same time this subtle change has the ability to blow up existing installs.
debug is a decent idea. I thought I saw a jira/pr go around about adding
markers to control logging? maybe that makes sense here to try?
I just think we need to be careful about default logging just surprising
folks operating Solr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
