stillalex commented on PR #1155: URL: https://github.com/apache/solr/pull/1155#issuecomment-1355742412
@debe I have finally had some time to update the benchmark to remove mockito and only use pure SolrCore code for verification. I think I have taken all the noise out of it, but unfortunately this is back to my initial results, showing a slowdown in the PR, could you take another look? [main branch](https://github.com/apache/solr/compare/main...stillalex:SOLR-16497-locks-bench?expand=1): ```Result "org.apache.solr.core.SolrCoresBenchTest.getCoreFromAnyList": 7013249.176 ±(99.9%) 420959.068 ops/s [Average] (min, avg, max) = (6986952.973, 7013249.176, 7030112.165), stdev = 23074.187 CI (99.9%): [6592290.109, 7434208.244] (assumes normal distribution) ``` PR ([main branch + pr patch](https://github.com/apache/solr/compare/main...stillalex:SOLR-16497-locks-bench-and-patch?expand=1)): ```Result "org.apache.solr.core.SolrCoresBenchTest.getCoreFromAnyList": 1492787.497 ±(99.9%) 567915.344 ops/s [Average] (min, avg, max) = (1468715.133, 1492787.497, 1527941.373), stdev = 31129.356 CI (99.9%): [924872.153, 2060702.841] (assumes normal distribution) ``` @dsmiley is the benchmark useful in its current form? I would like to contribute it along with the PR (seeing the results it probably still needs a few tweaks). let me know if this is something you are interested in, otherwise I can leave it out this conversation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
