patsonluk commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1054994623
##########
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##########
@@ -139,30 +138,10 @@ public static String getCollectionPathRoot(String coll) {
* only a replica is updated
*/
public DocCollection copyWith(PerReplicaStates newPerReplicaStates) {
Review Comment:
Based on the old code, the modified replicas would be read from the
newPerReplicaStates provided to construct a list as `modifiedShards` (which
each Slice value instead contains a map of replicas, which info relies on the
input `newPerReplicaStates`).
Since we are not constructing a new DocCollection here and instead returning
the same `this` instance, how can we ensure the such DocCollection instance
getSlice calls return the updated replica info from `newPerReplicaStates`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
