gerlowskija commented on code in PR #509:
URL: https://github.com/apache/solr-operator/pull/509#discussion_r1056521056
##########
controllers/solrbackup_controller.go:
##########
@@ -146,7 +145,7 @@ func (r *SolrBackupReconciler) Reconcile(ctx
context.Context, req ctrl.Request)
}
// Schedule the next backupTime, if it doesn't have a next scheduled
time, it has recurrence and the current backup is finished
- if backup.Status.IndividualSolrBackupStatus.Finished {
+ if backup.Status.IndividualSolrBackupStatus.Finished &&
backup.Spec.Recurrence.IsEnabled() {
Review Comment:
[+1] Weird that the comment on L147 mentions recurrence-being-enabled as
being a prereq, but we never checked for it before now. Must've just been an
oversight on my part?
Anyway, good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
