[
https://issues.apache.org/jira/browse/SOLR-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652477#comment-17652477
]
Eric Pugh edited comment on SOLR-10452 at 12/28/22 11:47 AM:
-------------------------------------------------------------
Hi all.... I'd love some guidence on this ticket, on what we should do? I
believe that setBaseUrl, setFollowRedirects, setAliveCheckInterval have all
moved to builder. setZkClientTimeout and setZkConnectTimeout are no longer on
the builder or the client, but on a different class, and we suspect won't be
actually moved to a builder. And setBasicAuthHeader appears to now be an
internal private method.
[~anshum] [~dsmiley] [~gerlowskija]
was (Author: epugh):
Hi all.... I'd love some guidence on this ticket, on what we should do? I
believe that setBaseUrl, setFollowRedirects, setAliveCheckInterval have all
moved to builder. setZkClientTimeout and setZkConnectTimeout are no longer on
the builder or the client, but on a different class, and we suspect won't be
actually moved to a builder. And setBasicAuthHeader appears to now be an
internal private method.
> setQueryParams should be deprecated in favor of SolrClientBuilder methods
> -------------------------------------------------------------------------
>
> Key: SOLR-10452
> URL: https://issues.apache.org/jira/browse/SOLR-10452
> Project: Solr
> Issue Type: Sub-task
> Components: SolrJ
> Reporter: Jason Gerlowski
> Priority: Minor
> Fix For: 7.0
>
> Attachments: SOLR-10452.patch
>
>
> Now that builders are in place for {{SolrClients}}, the setters used in each
> {{SolrClient}} can be deprecated, and their functionality moved over to the
> Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice
> to have all the knobs, and levers used to tweak {{SolrClient}}s available in
> a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are
> mutable. Using some {{SolrClient}} setters can result in erratic and "trappy"
> behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the {{setQueryParams}}
> setter on all {{SolrClient}} implementations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
