stillalex commented on code in PR #1253:
URL: https://github.com/apache/solr/pull/1253#discussion_r1058496938
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -991,6 +992,7 @@ public static class Builder {
private ExecutorService executor;
protected RequestWriter requestWriter;
protected ResponseParser responseParser;
+ private volatile Set<String> queryParams = Collections.emptySet();
Review Comment:
I don't think this needs to be 'volatile' anymore. also what about using
'Set.of()'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
