[
https://issues.apache.org/jira/browse/SOLR-16590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652827#comment-17652827
]
Eric Pugh commented on SOLR-16590:
----------------------------------
In working with the various Builders on the Solr clients, I notice a wide
variety of method names:
with: withBaseSolrUrl(String),
withHttpSolrClientBuilder(HttpSolrClientBuilder), withSSLConfig(SSLConfig)
set: setAliveCheckInterval(int),
allow: allowCompression(boolean). (And some others that imply a
decision in the name)
(No prefix) connectionTimeout(int), requestTimeout(int),
maxConnectionsPerHost(int)
Do we want to move towards using with everywhere? Should the no prefixed ones
at least have a set or with? Am I bike shedding too much ;-).
> Standardize Builder method names
> --------------------------------
>
> Key: SOLR-16590
> URL: https://issues.apache.org/jira/browse/SOLR-16590
> Project: Solr
> Issue Type: Sub-task
> Affects Versions: 9.0
> Reporter: Eric Pugh
> Priority: Major
>
> We use a mish mash of method name styles on builders.. Some sets, some
> withs, some sends, some straight up direct property name...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
