epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1060203187


##########
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##########
@@ -2669,6 +2669,18 @@ public static CloudSolrClient getCloudSolrClient(String 
zkHost) {
         .build();
   }
 
+  /**
+   * This method <i>may</i> randomize unspecified aspects of the resulting 
SolrClient. Tests that do
+   * not wish to have any randomized behavior should use the {@link
+   * org.apache.solr.client.solrj.impl.CloudSolrClient.Builder} class directly
+   */
+  public static CloudSolrClient getCloudSolrClient(String zkHost, String 
defaultCollection) {

Review Comment:
   Makes sense..   I went and looked, and they all pretty much were only used 
by 1 test method...   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to